Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup_after_CI_PR #16

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Cleanup_after_CI_PR #16

merged 5 commits into from
Jan 9, 2024

Conversation

ajkhattak
Copy link
Collaborator

@ajkhattak ajkhattak commented Jan 9, 2024 •
edited
Loading

Merging realization files resulted after Git Actions workflow PR. Since LGAR-C comes with its own CMakeList file and will be added as a ngen submodule to adopting the style extern/Model/Model/cmake_build

Additions

  • none

Removals

  • merged files

Changes

  • none

Testing

  1. Git Actions (only)

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests
  • Reviewers requested with the Reviewers tool ➡️

@ajkhattak ajkhattak requested a review from stcui007 January 9, 2024 15:59
@stcui007
Copy link
Contributor

stcui007 commented Jan 9, 2024

Looks good to me. One minor suggestion, in ngen_integration.yaml:

      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - name: checkout actions in another repo
        uses: actions/checkout@v4
        with:
          repository: noaa-owp/soilfreezethaw

To be consistent with the rest of libraries, you migth want to change the comment line to "Checlout and build SoilFreezeThaw"

@stcui007
Copy link
Contributor

stcui007 commented Jan 9, 2024

Another minor suggestion: You might want to the comment line to above the -name line.

      - name: Run Ngen Test with LASAM
        run: |
          # Run ngen with sft, smp, and lasam

@ajkhattak
Copy link
Collaborator Author

Changes incorporated. Thanks for reviewing @stcui007.

@ajkhattak ajkhattak merged commit a9e497d into master Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stcui007 stcui007 stcui007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajkhattak @stcui007